Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up include module #632

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Clean up include module #632

merged 3 commits into from
Mar 28, 2023

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Mar 27, 2023 •
edited
Loading

Part of #16.

Remove includes that contain detail-only functionality from e.g. pika/functional.hpp. Replace includes of pika/functional.hpp with more specific includes when required for detail functionality.

@msimberg msimberg added this to the 0.14.0 milestone Mar 27, 2023
@msimberg msimberg self-assigned this Mar 27, 2023
@msimberg
Copy link
Contributor Author

bors try

@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch---

Info

PropertyBeforeAfter
pika Commit190f1894592d0a
pika Datetime2022-09-16T08:18:06+00:002023-03-27T10:52:29+00:00
Envfile
Datetime2022-09-16T10:25:01.976661+02:002023-03-27T13:00:07.802586+02:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostnamenid00074nid00006
Clusternamedaintdaint

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

bors bot added a commit that referenced this pull request Mar 27, 2023
@bors
Try #632:
c3e3e57
@bors
Copy link
Contributor

bors bot commented Mar 27, 2023

try

Build failed:

@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
pika Commit190f18982b6f83
pika Datetime2022-09-16T08:18:06+00:002023-03-27T14:14:56+00:00
Datetime2022-09-16T10:25:01.976661+02:002023-03-27T16:20:17.127451+02:00
Clusternamedaintdaint
Hostnamenid00074nid00012
Envfile
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Mar 27, 2023
@bors
Try #632:
7b1dec9
@bors
Copy link
Contributor

bors bot commented Mar 27, 2023

try

Build failed:

msimberg added 2 commits March 27, 2023 16:41
@msimberg
Clean up include module
af9d56c 
Remove includes that contain detail-only functionality from e.g.
pika/functional.hpp. Replace includes of pika/functional.hpp with more
specific includes when required for detail functionality.
@msimberg
Add std::chrono check to inshpect include check
27b2c77
@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Mar 27, 2023
@bors
Try #632:
bcb0800
@bors
Copy link
Contributor

bors bot commented Mar 27, 2023

try

Build failed:

@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Mar 27, 2023
@bors
Try #632:
a57f130
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
pika Datetime2022-09-16T08:18:06+00:002023-03-27T15:07:51+00:00
pika Commit190f189bdb6794
Datetime2022-09-16T10:25:01.976661+02:002023-03-27T17:16:56.860873+02:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile
Hostnamenid00074nid00020
Clusternamedaintdaint

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch--

Info

PropertyBeforeAfter
pika Commit190f1892a7986d
pika Datetime2022-09-16T08:18:06+00:002023-03-27T15:13:11+00:00
Datetime2022-09-16T10:25:01.976661+02:002023-03-27T17:19:58.550622+02:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostnamenid00074nid00020
Envfile
Clusternamedaintdaint

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@bors
Copy link
Contributor

bors bot commented Mar 27, 2023

try

Build succeeded:

@msimberg
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 28, 2023

Build succeeded:

@bors bors bot merged commit f1ee355 into pika-org:main Mar 28, 2023
@msimberg msimberg mentioned this pull request Jun 12, 2023
Open
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer Awaiting requested review from aurianer aurianer is a code owner

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@msimberg msimberg

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@msimberg @pika-bot