Clean up init_runtime module
#634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
Performance test reportpika PerformanceComparison
Info
Explanation of Symbols
|
msimberg
force-pushed
the
cleanup-init_runtime
branch
from
98a4f7d to
487a7b0
Compare
|
bors try |
Performance test reportpika PerformanceComparison
Info
Explanation of Symbols
|
msimberg
force-pushed
the
cleanup-init_runtime
branch
from
487a7b0 to
d411954
Compare
|
bors merge |
Performance test reportpika PerformanceComparison
Info
Explanation of Symbols
|
bors bot
added a commit
that referenced
this pull request
Mar 28, 2023
628: Miscellaneous cleanup of debug print macros r=msimberg a=msimberg - Rename macros to be prefixed by `PIKA_DETAIL` - Remove unnecessary casts in debug print macro calls - Add note about meaning of detail to README 634: Clean up `init_runtime` module r=msimberg a=msimberg Part of #16. Move functionality into `detail` namespace, move functions into cpp files. 638: Fix option description for `PIKA_WITH_THREAD_DEBUG_INFO` r=msimberg a=msimberg The option is not implicitly enabled in debug builds. Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Mar 28, 2023
634: Clean up `init_runtime` module r=msimberg a=msimberg Part of #16. Move functionality into `detail` namespace, move functions into cpp files. 638: Fix option description for `PIKA_WITH_THREAD_DEBUG_INFO` r=msimberg a=msimberg The option is not implicitly enabled in debug builds. Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
|
Build failed (retrying...): |
59 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #16.
Move functionality into
detailnamespace, move functions into cpp files.