Remove fast_idle and delay_exit scheduler modes and related scheduling loop checks
#664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not really affect performance in DLA-Future or in the future overhead test, but it simplifies the scheduling loop noticeably so I'd like to keep this change. The only open question is the same as #665 (comment), i.e. whether the scheduler mode enums should be renumbered. @biddisco? |
|
bors try |
biddisco
approved these changes
Apr 26, 2023
msimberg
force-pushed
the
remove-fast-idle-scheduling-loop
branch
from
8f0875b to
b2e6061
Compare
msimberg
force-pushed
the
remove-fast-idle-scheduling-loop
branch
from
b2e6061 to
b5d852b
Compare
|
bors try |
tryBuild failed: |
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fifth of N PRs to try to improve performance in DLA-Future. This is one of the changes in main...disable-cruft-scheduler where we see up to 25% improvement in DLA-Future miniapps. This branch needs to be benchmarked to see if it makes a difference on its own.
One change that have in the
disable-cruft-schedulerbranch is to unconditionally enable stealing always. It may be worth checking if that makes a difference, though I suspect the effect may be small.