Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stdexec #678

Merged
merged 13 commits into from
May 12, 2023
Merged

Update stdexec #678

merged 13 commits into from
May 12, 2023

Conversation

aurianer
Copy link
Contributor

@aurianer aurianer commented May 8, 2023 •
edited
Loading

@aurianer aurianer added this to the 0.16.0 milestone May 8, 2023
@aurianer aurianer self-assigned this May 8, 2023
@msimberg
Copy link
Contributor

msimberg commented May 9, 2023

bors try

bors bot added a commit that referenced this pull request May 9, 2023
@bors
Try #678:
3e92571
@bors
Copy link
Contributor

bors bot commented May 9, 2023

try

Build failed:

@aurianer aurianer force-pushed the try_stdexec_main branch from b257ae3 to e777dcf Compare May 9, 2023 10:23
@pika-bot
Copy link
Collaborator

pika-bot commented May 9, 2023

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Commit97100fba810bfc
pika Datetime2023-04-24T15:38:14+00:002023-05-09T10:23:24+00:00
Datetime2023-04-24T17:46:47.209658+02:002023-05-09T12:30:26.140509+02:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clusternamedaintdaint
Envfile
Hostnamenid00269nid01193

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@msimberg msimberg mentioned this pull request May 9, 2023
Merged
@aurianer aurianer force-pushed the try_stdexec_main branch from e777dcf to 4c9a5c2 Compare May 9, 2023 14:16
@aurianer aurianer changed the title Try stdexec main Try stdexec 7a47a4aa411c1ca9adfcb152c28cc3dd7b156b4d May 9, 2023
@aurianer aurianer changed the title Try stdexec 7a47a4aa411c1ca9adfcb152c28cc3dd7b156b4d Try stdexec 7a47a4aa May 9, 2023
@aurianer aurianer changed the title Try stdexec 7a47a4aa Update stdexec in pika May 9, 2023
@aurianer
Copy link
Contributor Author

aurianer commented May 9, 2023

bors try

bors bot added a commit that referenced this pull request May 9, 2023
@bors
Try #678:
ab21970
@bors
Copy link
Contributor

bors bot commented May 9, 2023

try

Build failed:

@aurianer
Copy link
Contributor Author

aurianer commented May 9, 2023

bors try

bors bot added a commit that referenced this pull request May 9, 2023
@bors
Try #678:
d1fbfe4
@bors
Copy link
Contributor

bors bot commented May 9, 2023

try

Build failed:

@aurianer aurianer force-pushed the try_stdexec_main branch from 4c00637 to 2d260f0 Compare May 9, 2023 15:48
@aurianer
Copy link
Contributor Author

aurianer commented May 9, 2023

bors try

bors bot added a commit that referenced this pull request May 9, 2023
@bors
Try #678:
f041967
@bors
Copy link
Contributor

bors bot commented May 9, 2023

try

Build failed:

@pika-bot
Copy link
Collaborator

pika-bot commented May 9, 2023

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Datetime2023-04-24T15:38:14+00:002023-05-09T15:48:40+00:00
pika Commit97100fb1b5ba38
Hostnamenid00269nid00275
Envfile
Datetime2023-04-24T17:46:47.209658+02:002023-05-09T18:02:15.050185+02:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clusternamedaintdaint

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@aurianer aurianer force-pushed the try_stdexec_main branch from 2d260f0 to 95fcbdc Compare May 9, 2023 16:09
@aurianer
Copy link
Contributor Author

aurianer commented May 9, 2023

bors try

bors bot added a commit that referenced this pull request May 9, 2023
@bors
Try #678:
3c7ac4d
@aurianer aurianer force-pushed the try_stdexec_main branch from 95fcbdc to 6dd100c Compare May 10, 2023 13:59
@aurianer
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 10, 2023
@bors
Try #678:
04dcfc3
@bors
Copy link
Contributor

bors bot commented May 10, 2023

try

Build failed:

@msimberg
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request May 10, 2023
@bors
Try #678:
b761815
@bors
Copy link
Contributor

bors bot commented May 10, 2023

try

Build failed:

@aurianer
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 11, 2023
@bors
Try #678:
86eef5a
@bors
Copy link
Contributor

bors bot commented May 11, 2023

try

Build failed:

@aurianer aurianer force-pushed the try_stdexec_main branch from fd54e18 to 430b62b Compare May 11, 2023 13:04
@aurianer aurianer marked this pull request as ready for review May 11, 2023 13:04
@aurianer aurianer requested a review from biddisco as a code owner May 11, 2023 13:04
@aurianer
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 11, 2023
@bors
Try #678:
8e9f05e
@bors
Copy link
Contributor

bors bot commented May 11, 2023

try

Build failed:

@aurianer
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 12, 2023
@bors
Try #678:
67a6e1a
@bors
Copy link
Contributor

bors bot commented May 12, 2023

try

Build failed:

msimberg
msimberg approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@msimberg msimberg changed the title Update stdexec in pika Update stdexec May 12, 2023
@msimberg msimberg merged commit e9662f5 into pika-org:main May 12, 2023
@msimberg msimberg mentioned this pull request May 15, 2023
Closed
@msimberg msimberg mentioned this pull request May 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@aurianer aurianer

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aurianer @msimberg @pika-bot