Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings about includes and #pragma once #697

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Fix warnings about includes and #pragma once #697

merged 1 commit into from
Jun 16, 2023

Conversation

biddisco
Copy link
Contributor

Fix a couple of warnings/errors that appeared when unity build was disabled.

@msimberg msimberg changed the title Fix warnings about includes and #pragma once Fix warnings about includes and #pragma once Jun 15, 2023
@msimberg
Copy link
Contributor

bors merge

bors bot added a commit that referenced this pull request Jun 15, 2023
@bors @biddisco
Merge #697
c9cc1ee 
697: Fix warnings about includes and `#pragma once` r=msimberg a=biddisco

Fix a couple of warnings/errors that appeared when unity build was disabled. 

Co-authored-by: John Biddiscombe <biddisco@cscs.ch>
@bors
Copy link
Contributor

bors bot commented Jun 15, 2023

Build failed:

@msimberg
Copy link
Contributor

bors merge

bors bot added a commit that referenced this pull request Jun 16, 2023
@bors @biddisco
Merge #697 #698
6b56a7d 
697: Fix warnings about includes and `#pragma once` r=msimberg a=biddisco

Fix a couple of warnings/errors that appeared when unity build was disabled. 

698: Debug print cleanup r=msimberg a=biddisco

Just some flyby cleanups that are separated from other PRs

Co-authored-by: John Biddiscombe <biddisco@cscs.ch>
@bors
Copy link
Contributor

bors bot commented Jun 16, 2023

Build failed (retrying...):

bors bot added a commit that referenced this pull request Jun 16, 2023
@bors @biddisco
Merge #697
aa2339d 
697: Fix warnings about includes and `#pragma once` r=msimberg a=biddisco

Fix a couple of warnings/errors that appeared when unity build was disabled. 

Co-authored-by: John Biddiscombe <biddisco@cscs.ch>
@bors
Copy link
Contributor

bors bot commented Jun 16, 2023

Timed out.

@aurianer
Copy link
Contributor

bors merge

bors bot added a commit that referenced this pull request Jun 16, 2023
@bors @biddisco
Merge #697
a06eceb 
697: Fix warnings about includes and `#pragma once` r=aurianer a=biddisco

Fix a couple of warnings/errors that appeared when unity build was disabled. 

Co-authored-by: John Biddiscombe <biddisco@cscs.ch>
@msimberg
Copy link
Contributor

It looks like the ault CI is currently not running. Merging manually since this is unlikely to break anything there.

@msimberg msimberg merged commit 48c462e into main Jun 16, 2023
@bors bors bot deleted the unity_warnings branch June 16, 2023 14:32
@bors
Copy link
Contributor

bors bot commented Jun 16, 2023

Timed out.

@msimberg msimberg added this to the 0.17.0 milestone Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

@aurianer aurianer Awaiting requested review from aurianer aurianer is a code owner

Assignees

@biddisco biddisco

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@biddisco @msimberg @aurianer