Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach debugger after printing failure information #712

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Attach debugger after printing failure information #712

merged 1 commit into from
Jul 12, 2023

Conversation

msimberg
Copy link
Contributor

When an assertion is handled we optionally allow attaching a debugger before terminating. Currently on main the debugger can be attached before printing the error message. This PR moves may_attach_debugger to after the error message has been printed so that one can see the reason for failure before deciding to attach a debugger.

@msimberg msimberg added this to the 0.17.0 milestone Jul 11, 2023
@msimberg msimberg self-assigned this Jul 11, 2023
@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jul 11, 2023
@bors
Try #712:
b07a1ad
@bors
Copy link
Contributor

bors bot commented Jul 11, 2023

try

Build failed:

@msimberg
Copy link
Contributor Author

bors try

aurianer
aurianer approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

bors bot added a commit that referenced this pull request Jul 11, 2023
@bors
Try #712:
668d70e
@bors
Copy link
Contributor

bors bot commented Jul 11, 2023

try

Build failed:

@msimberg msimberg merged commit 03156cd into pika-org:main Jul 12, 2023
@msimberg msimberg deleted the attach-debugger-later branch July 12, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer aurianer approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@msimberg msimberg

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@msimberg @aurianer