Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix freeing stack when guard pages are disabled #716

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Fix freeing stack when guard pages are disabled #716

merged 2 commits into from
Jul 19, 2023

Conversation

msimberg
Copy link
Contributor

When guard pages are disabled, we were still allocating an extra page as if we were using guard pages but then deallocating as if we're not using guard pages. This lead to memory leaks.

Fixes #715.

@msimberg msimberg added this to the 0.17.0 milestone Jul 17, 2023
@msimberg msimberg self-assigned this Jul 17, 2023
@msimberg msimberg requested review from rasolca, albestro and RMeli July 17, 2023 15:36
@msimberg msimberg force-pushed the fix-free_stack-no-guard-pages branch from 6d27594 to de01a59 Compare July 17, 2023 15:45
@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jul 17, 2023
@bors
Try #716:
df078bf
@bors
Copy link
Contributor

bors bot commented Jul 17, 2023

try

Build failed:

@msimberg msimberg force-pushed the fix-free_stack-no-guard-pages branch from de01a59 to 7392b38 Compare July 17, 2023 17:16
@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jul 17, 2023
@bors
Try #716:
4e54193
@bors
Copy link
Contributor

bors bot commented Jul 17, 2023

try

Build failed:

@msimberg msimberg force-pushed the fix-free_stack-no-guard-pages branch from 7392b38 to 8750022 Compare July 17, 2023 17:23
@msimberg
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Jul 17, 2023
@bors
Try #716:
eab5761
@bors
Copy link
Contributor

bors bot commented Jul 17, 2023

try

Build failed:

@RMeli RMeli mentioned this pull request Jul 18, 2023
Merged
24 tasks
RMeli
RMeli approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eth-cscs/DLA-Future#886 (comment)

@msimberg
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 19, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit d98a840 into pika-org:main Jul 19, 2023
@msimberg msimberg deleted the fix-free_stack-no-guard-pages branch July 19, 2023 11:13
@RMeli RMeli mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMeli RMeli RMeli approved these changes

@aurianer aurianer Awaiting requested review from aurianer aurianer is a code owner

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

@rasolca rasolca Awaiting requested review from rasolca

@albestro albestro Awaiting requested review from albestro

Assignees

@msimberg msimberg

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.

Starting and stopping the runtime repeatedly seems to leak resources/memory on some systems
2 participants
@msimberg @RMeli