Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix apt warning in arm64 CircleCI #734

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Fix apt warning in arm64 CircleCI #734

merged 2 commits into from
Aug 11, 2023

Conversation

aurianer
Copy link
Contributor

@aurianer aurianer commented Aug 9, 2023 •
edited
Loading

Fixes the warning W: --force-yes is deprecated, use one of the options starting with --allow instead.

@aurianer aurianer added this to the 0.18.0 milestone Aug 9, 2023
@aurianer aurianer self-assigned this Aug 9, 2023
@msimberg
Copy link
Contributor

msimberg commented Aug 9, 2023

Could you clarify what this fixes? Please separate this from the changes in #702.

@aurianer
Copy link
Contributor Author

yes clarified in the description, doesn't solve the occasional failures we have seen though

@msimberg
Copy link
Contributor

yes clarified in the description, doesn't solve the occasional failures we have seen though

Indeed, CircleCI was having a lot of trouble yesterday so this warning is definitely unrelated.

What you could do though is add an apt update before the apt install. It could've been a case of the repository lists simply being out of date.

msimberg
msimberg approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@msimberg
Copy link
Contributor

bors merge

@msimberg
Copy link
Contributor

bors cancel

@bors
Copy link
Contributor

bors bot commented Aug 11, 2023

Canceled.

bors bot added a commit that referenced this pull request Aug 11, 2023
@bors @aurianer
Merge #734
a12a212 
734: Arm64 CI fix warning r=msimberg a=aurianer

Fixes the warning `W: --force-yes is deprecated, use one of the options starting with --allow instead.`

Co-authored-by: aurianer <aurianer@cscs.ch>
@msimberg msimberg changed the title Arm64 CI fix warning Fix apt warning in arm64 CircleCI Aug 11, 2023
@msimberg
Copy link
Contributor

bors merge

bors bot added a commit that referenced this pull request Aug 11, 2023
@bors @aurianer
Merge #734
4471243 
734: Fix apt warning in arm64 CircleCI r=msimberg a=aurianer

Fixes the warning `W: --force-yes is deprecated, use one of the options starting with --allow instead.`

Co-authored-by: aurianer <aurianer@cscs.ch>
@msimberg
Copy link
Contributor

Merging manually as this doesn't affect anything other than the arm 64 CI (which passed).

@msimberg msimberg merged commit 62e8f38 into pika-org:main Aug 11, 2023
@bors
Copy link
Contributor

bors bot commented Aug 11, 2023

Timed out.

@aurianer aurianer deleted the arm_fix_warning branch July 2, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@aurianer aurianer

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aurianer @msimberg