Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial CI pipeline with CSCS-CI #771

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Add initial CI pipeline with CSCS-CI #771

merged 3 commits into from
Sep 19, 2023

Conversation

aurianer
Copy link
Contributor

@aurianer aurianer commented Sep 12, 2023 •
edited
Loading

Fix partially #32.
Sets the initial pipeline using CSCS-CI with the docker base image.

Note: I didn't remove the {SOURCE,BUILD}_DIR defaults in the docker image as it makes it easier to run it locally.

@aurianer aurianer self-assigned this Sep 12, 2023
@aurianer aurianer force-pushed the cscsci-ext branch 2 times, most recently from 3c3c76d to 4357b34 Compare September 12, 2023 09:26
@aurianer
Copy link
Contributor Author

cscs-ci run

@aurianer aurianer force-pushed the cscsci-ext branch 14 times, most recently from db90e6f to 5d39194 Compare September 13, 2023 09:04
@msimberg msimberg added this to the 0.19.0 milestone Sep 13, 2023
@aurianer aurianer force-pushed the cscsci-ext branch 11 times, most recently from 27e1039 to 96f2e7a Compare September 13, 2023 16:30
@aurianer aurianer force-pushed the cscsci-ext branch 4 times, most recently from 3a52b43 to 078318b Compare September 15, 2023 11:38
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Commit02f9de8a700aa9
pika Datetime2023-08-21T11:44:55+00:002023-09-15T11:38:31+00:00
Datetime2023-08-21T13:50:51.685166+02:002023-09-15T13:45:11.827093+02:00
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile
Hostnamenid01181nid01260

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@aurianer
Copy link
Contributor Author

aurianer commented Sep 18, 2023 •
edited
Loading

cscs-ci run
EDIT: I tried to rerun it manually but it seems that it's stuck to rerunning via comment now..

msimberg
msimberg reviewed Sep 18, 2023
View reviewed changes
ci/docker/Dockerfile.build Outdated Show resolved Hide resolved
ci/docker/Dockerfile.build Outdated Show resolved Hide resolved
ci/docker/Dockerfile.build Outdated Show resolved Hide resolved
ci/docker/Dockerfile.build Outdated Show resolved Hide resolved
ci/docker/Dockerfile.build Outdated Show resolved Hide resolved
ci/docker/Dockerfile.build Outdated Show resolved Hide resolved
ci/pipeline.yml Outdated Show resolved Hide resolved
ci/pipeline.yml Outdated Show resolved Hide resolved
ci/docker/Dockerfile.build Outdated Show resolved Hide resolved
ci/pipeline.yml Outdated Show resolved Hide resolved
@aurianer aurianer marked this pull request as ready for review September 18, 2023 13:30
@aurianer aurianer requested a review from biddisco as a code owner September 18, 2023 13:30
@aurianer
Copy link
Contributor Author

I excluded the std_thread_scheduler test and I opened #777 to fix the problem in another PR.

msimberg
msimberg reviewed Sep 18, 2023
View reviewed changes
.gitlab/pipeline.yml Outdated Show resolved Hide resolved
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Datetime2023-08-21T11:44:55+00:002023-09-18T15:36:55+00:00
pika Commit02f9de81ca0d36
Hostnamenid01181nid00186
Envfile
Datetime2023-08-21T13:50:51.685166+02:002023-09-18T17:49:44.582301+02:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clusternamedaintdaint

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

msimberg
msimberg approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work so far on this @aurianer!

This is ready to be used already in my opinion and you can go ahead and merge it if you like.

I've added two more potential cleanup comments, but I'm not sure both of them are possible to do, and they are not blockers. They can be done at a later point as well.

For later: we should add this to the GitHub merge queue required checks, but at the moment I think this pipeline will not be triggered because of the merge queue branch name.

.gitlab/docker/Dockerfile.build Outdated Show resolved Hide resolved
.gitlab/pipeline.yml Outdated Show resolved Hide resolved
@aurianer aurianer force-pushed the cscsci-ext branch 3 times, most recently from 2c11e11 to 4f56ada Compare September 19, 2023 08:15
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Commit02f9de84bb93b4
pika Datetime2023-08-21T11:44:55+00:002023-09-19T08:22:20+00:00
Clusternamedaintdaint
Datetime2023-08-21T13:50:51.685166+02:002023-09-19T10:30:52.424895+02:00
Hostnamenid01181nid00271
Envfile
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@aurianer aurianer enabled auto-merge September 19, 2023 08:59
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Datetime2023-08-21T11:44:55+00:002023-09-19T08:55:23+00:00
pika Commit02f9de8b161d8b
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Envfile
Clusternamedaintdaint
Datetime2023-08-21T13:50:51.685166+02:002023-09-19T11:12:43.835686+02:00
Hostnamenid01181nid00584

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@aurianer aurianer added this pull request to the merge queue Sep 19, 2023
Merged via the queue into main with commit 75f6331 Sep 19, 2023
@bors bors bot deleted the cscsci-ext branch September 19, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@aurianer aurianer

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aurianer @pika-bot @msimberg