Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drop_operation_state sender adaptor #772

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

msimberg
Copy link
Contributor

drop_operation_state will release any operation state coming before the adaptor before signaling a connected receiver. Values sent as references will be copied before being passed on to successors.

Related to #479.

@msimberg msimberg added this to the 0.19.0 milestone Sep 12, 2023
@msimberg msimberg self-assigned this Sep 12, 2023
@msimberg msimberg force-pushed the drop-operation-state branch 4 times, most recently from ee9b98c to 66b0e60 Compare September 12, 2023 14:54
@msimberg msimberg marked this pull request as ready for review September 13, 2023 10:15
@msimberg msimberg force-pushed the drop-operation-state branch from 66b0e60 to ef02645 Compare September 22, 2023 13:46
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

drop_operation_state will release any operation state coming before the adaptor before signaling a
connected receiver. Values sent as references will be copied before being passed on to successors.
@msimberg msimberg force-pushed the drop-operation-state branch from ef02645 to cb7e531 Compare October 3, 2023 15:13
@msimberg msimberg enabled auto-merge October 3, 2023 15:13
@msimberg msimberg added this pull request to the merge queue Oct 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2023
@msimberg msimberg added this pull request to the merge queue Oct 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2023
@aurianer aurianer merged commit e7961b7 into pika-org:main Oct 4, 2023
13 of 14 checks passed
@msimberg msimberg deleted the drop-operation-state branch October 4, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants