Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PIKA_WITH_THREAD_GUARD_PAGE CMake option #782

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Remove PIKA_WITH_THREAD_GUARD_PAGE CMake option #782

merged 1 commit into from
Sep 19, 2023

Conversation

msimberg
Copy link
Contributor

This option can be controlled sufficiently at runtime.

@msimberg
Remove PIKA_WITH_THREAD_GUARD_PAGE CMake option
64a2482 
This option is fully controlled at runtime.
@msimberg msimberg added this to the 0.19.0 milestone Sep 19, 2023
@msimberg msimberg requested a review from aurianer as a code owner September 19, 2023 12:43
@msimberg msimberg self-assigned this Sep 19, 2023
@msimberg msimberg requested a review from biddisco as a code owner September 19, 2023 12:43
@msimberg msimberg enabled auto-merge September 19, 2023 12:43
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Datetime2023-08-21T11:44:55+00:002023-09-19T12:43:16+00:00
pika Commit02f9de88cda099
Hostnamenid01181nid00805
Clusternamedaintdaint
Envfile
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Datetime2023-08-21T13:50:51.685166+02:002023-09-19T14:52:59.730266+02:00

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@msimberg msimberg added this pull request to the merge queue Sep 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2023
@msimberg msimberg added this pull request to the merge queue Sep 19, 2023
aurianer
aurianer approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Merged via the queue into pika-org:main with commit e5ee399 Sep 19, 2023
13 checks passed
@msimberg msimberg deleted the remove-guard-pages-cmake-option branch September 19, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer aurianer approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@msimberg msimberg

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@msimberg @pika-bot @aurianer