Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print MPI rank in place of locality in --pika:print-bind #805

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

msimberg
Copy link
Contributor

Until now we've been printing the locality in --pika:print-bind but it's always zero. This changes it to print the MPI rank (if pika was compiled with MPI support).

@msimberg msimberg added this to the 0.20.0 milestone Oct 12, 2023
@msimberg msimberg self-assigned this Oct 12, 2023
@msimberg msimberg marked this pull request as ready for review October 12, 2023 10:49
@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Commit02f9de8b81d631
pika Datetime2023-08-21T11:44:55+00:002023-10-12T10:49:27+00:00
Envfile
Clusternamedaintdaint
Hostnamenid01181nid01183
Datetime2023-08-21T13:50:51.685166+02:002023-10-12T12:55:31.913241+02:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@msimberg msimberg added this pull request to the merge queue Oct 13, 2023
Merged via the queue into pika-org:main with commit 8b870b5 Oct 13, 2023
14 checks passed
@msimberg msimberg deleted the print-bind-no-locality branch October 16, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants