Revert #774 #831
Merged
Revert #774 #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
cscs-ci run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #774 for compatibility-related reasons for the 0.20.0 release. I will un-revert the changes again for 0.21.0.
The CP2K integration of DLA-Future (and thus pika) benefits greatly from #807, which will be included in 0.20.0. The latest release of DLA-Future is 0.2.1 which still requires pika-algorithms, and including #774 in 0.20.0 breaks pika-algorithms. By keeping #774 in 0.20.0 there would be no released version of pika that can be used with CP2K and DLA-Future 0.2.1 (0.20.0 breaks pika-algorithms, and 0.19.0 doesn't have #807). By postponing #774 to 0.21.0 the initial CP2K integration can use DLA-Future 0.2.1 and pika 0.20.0.