Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PIKA_WITH_PARALLEL_TESTS_BIND_NONE in CSCS CI #873

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Add PIKA_WITH_PARALLEL_TESTS_BIND_NONE in CSCS CI #873

merged 1 commit into from
Dec 4, 2023

Conversation

aurianer
Copy link
Contributor

It was enabled by default in ctest.cmake in jenkins (cf https://github.com/pika-org/pika/blob/main/.jenkins/cscs/ctest.cmake#L69)

@aurianer
Add PIKA_WITH_PARALLEL_TESTS_BIND_NONE
4d6cad2 
It was enabled by default in ctest.cmake in jenkins
@aurianer aurianer added the category: CI Continuous Integration label Nov 30, 2023
@aurianer aurianer added this to the 0.21.0 milestone Nov 30, 2023
@aurianer
Copy link
Contributor Author

cscs-ci run

msimberg
msimberg approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks. This is likely a required addition to #866 to avoid test timeouts. If we still see issues after this I think we can start suspecting the tests themselves rather than the test setup.

@msimberg
Copy link
Contributor

msimberg commented Dec 4, 2023

Are you planning further changes to this PR? It looks ready to go.

@aurianer aurianer marked this pull request as ready for review December 4, 2023 12:04
@aurianer aurianer requested a review from biddisco as a code owner December 4, 2023 12:04
@msimberg msimberg added this pull request to the merge queue Dec 4, 2023
Merged via the queue into pika-org:main with commit 36a51db Dec 4, 2023
67 checks passed
@aurianer aurianer self-assigned this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@aurianer aurianer

Labels
category: CI Continuous Integration
Projects
pika planning board
Status: Archive
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aurianer @msimberg