Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gcc10 apex pipeline in CSCS CI #930

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Add gcc10 apex pipeline in CSCS CI #930

merged 4 commits into from
Jan 16, 2024

Conversation

aurianer
Copy link
Contributor

@aurianer aurianer commented Jan 5, 2024 •
edited by msimberg
Loading

Fix #926. Allow deprecated packages (for apex 2.4.1), otherwise concretization is failing (see spack/spack#42037). apex version will be updated separately, see #948.

@aurianer aurianer added the category: CI Continuous Integration label Jan 5, 2024
@aurianer aurianer added this to the 0.22.0 milestone Jan 5, 2024
@aurianer aurianer self-assigned this Jan 5, 2024
@aurianer
Copy link
Contributor Author

aurianer commented Jan 5, 2024

cscs-ci run

@aurianer aurianer mentioned this pull request Jan 5, 2024
Open
16 tasks
@aurianer aurianer force-pushed the add_gcc10_apex_configuration branch from 118090c to ac85e58 Compare January 10, 2024 20:39
@aurianer
Copy link
Contributor Author

cscs-ci run

@aurianer aurianer force-pushed the add_gcc10_apex_configuration branch from ac85e58 to f2ac4e6 Compare January 10, 2024 20:48
@aurianer
Copy link
Contributor Author

cscs-ci run

@msimberg
Copy link
Contributor

It's perhaps worth quickly just trying the non-deprecated versions first just in case it works, then you don't have to bother with special handling. If it doesn't work for some reason, then you can weigh if it's easier to fix the non-deprecated version or convince spack to use the old deprecated version.

@aurianer aurianer force-pushed the add_gcc10_apex_configuration branch from f2ac4e6 to b20e6e8 Compare January 11, 2024 12:52
@aurianer
Copy link
Contributor Author

cscs-ci run

1 similar comment
@aurianer
Copy link
Contributor Author

cscs-ci run

@aurianer aurianer force-pushed the add_gcc10_apex_configuration branch from 0226319 to 083424e Compare January 11, 2024 19:25
@aurianer
Copy link
Contributor Author

cscs-ci run

@msimberg
Copy link
Contributor

I think the current build failure comes from 2.4.X not supporting OTF2-3.X. We've seen this before but never bothered looking into it or adding conflicts. However, it looks like it's been fixed in UO-OACISS/apex@4a7bdbb (which is in apex 2.6.0 onwards). Perhaps you can add a conflict for this to the spack package (and if you want for now explicitly request OTF2 < 3.X for the build here)?

@aurianer
Copy link
Contributor Author

cscs-ci run

@aurianer
Copy link
Contributor Author

opened spack/spack#42060

@aurianer aurianer force-pushed the add_gcc10_apex_configuration branch from 79db050 to efdd238 Compare January 12, 2024 15:22
@aurianer
Copy link
Contributor Author

cscs-ci run

2 similar comments
@aurianer
Copy link
Contributor Author

cscs-ci run

@aurianer
Copy link
Contributor Author

cscs-ci run

@aurianer aurianer marked this pull request as ready for review January 15, 2024 07:36
@aurianer
Copy link
Contributor Author

For me this is good to go, I will investigate the segfaults with the new apex #948 in another PR

msimberg
msimberg requested changes Jan 15, 2024
View reviewed changes
.gitlab/docker/Dockerfile.spack_build Outdated Show resolved Hide resolved
.gitlab/docker/Dockerfile.spack_compiler Outdated Show resolved Hide resolved
.gitlab/includes/gcc10_apex_pipeline.yml Outdated Show resolved Hide resolved
.gitlab/includes/gcc10_apex_pipeline.yml Show resolved Hide resolved
.gitlab/pipeline.yml Outdated Show resolved Hide resolved
@aurianer aurianer force-pushed the add_gcc10_apex_configuration branch 2 times, most recently from 22aa26c to beeb3df Compare January 15, 2024 11:50
@aurianer
Copy link
Contributor Author

cscs-ci run

msimberg
msimberg requested changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, just a couple of minor tweaks needed.

.gitlab/docker/Dockerfile.spack_compiler Outdated Show resolved Hide resolved
.gitlab/docker/Dockerfile.spack_compiler Outdated Show resolved Hide resolved
@aurianer aurianer force-pushed the add_gcc10_apex_configuration branch from beeb3df to 39906d5 Compare January 15, 2024 14:12
@aurianer
Copy link
Contributor Author

cscs-ci run

@msimberg msimberg enabled auto-merge January 16, 2024 08:21
@msimberg msimberg added this pull request to the merge queue Jan 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2024
@msimberg
Copy link
Contributor

Merging manually. The failing test is condition_variable2 on the CCE configuration (which is already reported in #191).

@msimberg msimberg merged commit 644b836 into pika-org:main Jan 16, 2024
64 of 66 checks passed
@msimberg msimberg mentioned this pull request Jan 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@aurianer aurianer

Labels
category: CI Continuous Integration
Projects
pika planning board
Archived in project
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.

CSCS-CI related issues
2 participants
@aurianer @msimberg