Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing runtime include for non-unity build #955

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Fix missing runtime include for non-unity build #955

merged 1 commit into from
Jan 12, 2024

Conversation

biddisco
Copy link
Contributor

No description provided.

@msimberg msimberg changed the title Fix missing runtime include (non unity build) Fix missing runtime include for non-unity build Jan 12, 2024
@msimberg
Copy link
Contributor

Thanks for catching this @biddisco. This was clearly a gap in our testing so I've added a build with PIKA_WITH_UNITY_BUILD=OFF in #956. It also caught this missing include: https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/479009878135925/5304355110917878/-/jobs/5916526262.

@msimberg
Copy link
Contributor

cscs-ci run

@msimberg msimberg enabled auto-merge January 12, 2024 08:03
@msimberg msimberg added this pull request to the merge queue Jan 12, 2024
Merged via the queue into pika-org:main with commit 0acfef1 Jan 12, 2024
65 of 66 checks passed
@msimberg msimberg added this to the 0.22.0 milestone Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

@aurianer aurianer Awaiting requested review from aurianer aurianer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@biddisco @msimberg