Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CSCS CI to avoid duplications #975

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Refactor CSCS CI to avoid duplications #975

merged 5 commits into from
Jan 24, 2024

Conversation

aurianer
Copy link
Contributor

@aurianer aurianer commented Jan 18, 2024 •
edited
Loading

Fix #862

@aurianer aurianer added the category: CI Continuous Integration label Jan 18, 2024
@aurianer aurianer added this to the 0.22.0 milestone Jan 18, 2024
@aurianer aurianer self-assigned this Jan 18, 2024
@aurianer aurianer force-pushed the refactor_ci branch 6 times, most recently from da32706 to be6f53d Compare January 19, 2024 12:50
@aurianer
Copy link
Contributor Author

cscs-ci run

@aurianer
Copy link
Contributor Author

cscs-ci run

@aurianer
Copy link
Contributor Author

cscs-ci run

@aurianer aurianer changed the title [Very much WIP] Refactor CSCS CI using gitlab CI templates Refactor CSCS CI using gitlab CI templates Jan 22, 2024
@aurianer
Copy link
Contributor Author

cscs-ci run

@msimberg msimberg modified the milestones: 0.22.0, 0.23.0 Jan 22, 2024
@aurianer aurianer marked this pull request as ready for review January 23, 2024 10:42
msimberg
msimberg requested changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor cleanup and a few clarifying questions before approval. This looks like huge improvement, thank you!

.gitlab/includes/clang11_pipeline.yml Outdated Show resolved Hide resolved
.gitlab/includes/common_spack_pipeline.yml Outdated Show resolved Hide resolved
.gitlab/includes/common_spack_pipeline.yml Outdated Show resolved Hide resolved
.gitlab/includes/clang14_cuda11_pipeline.yml Show resolved Hide resolved
.gitlab/includes/clang11_pipeline.yml Outdated Show resolved Hide resolved
@aurianer
Copy link
Contributor Author

cscs-ci run ci-on-merge

@aurianer
Copy link
Contributor Author

The failures seems unrelated (probably filesystem issues), the tests passed

@aurianer
Copy link
Contributor Author

cscs-ci run ci-on-merge

msimberg
msimberg approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always welcome: +160 −894. Thank you!

@aurianer aurianer enabled auto-merge January 24, 2024 07:44
@msimberg
Copy link
Contributor

Merging manually because of clariden CI runners being down. CI looks good otherwise.

@msimberg msimberg disabled auto-merge January 24, 2024 08:37
@msimberg msimberg merged commit 23ea3a2 into pika-org:main Jan 24, 2024
50 of 56 checks passed
@msimberg msimberg modified the milestones: 0.23.0, 0.22.0 Jan 24, 2024
@aurianer aurianer mentioned this pull request Jan 27, 2024
Closed
@aurianer aurianer changed the title Refactor CSCS CI using gitlab CI templates Refactor CSCS CI to avoid duplications Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@aurianer aurianer

Labels
category: CI Continuous Integration
Projects
pika planning board
Archived in project
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.

Reduce duplication in CSCS CI configurations
2 participants
@aurianer @msimberg