Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@state doesn't exist, must be @_state (master branch) #15

Closed
wants to merge 1 commit into from
Closed

@state doesn't exist, must be @_state (master branch) #15

wants to merge 1 commit into from

Conversation

michbeck100
Copy link
Contributor

This hopefully fixes michbeck100/pimatic-hap#37

@michbeck100 michbeck100 changed the title @state doesn't exist, must be @_state. @state doesn't exist, must be @_state (master branch) Jul 11, 2016
@mwittig
Copy link
Collaborator

mwittig commented Jul 12, 2016

With which version did you test this and which error message did you get? Thanks

@michbeck100
Copy link
Contributor Author

I didn't have to test this and I don't get an error, because the code runs just fine. It just doesn't work, because there is no global variable called @State. The only variable you can use is @_state. I came over this because of an issue with pimatic-hap and the Shellswitch. Then I looked at the sources and saw this.

@michbeck100
Copy link
Contributor Author

In fact, a lot of issues people have with pimatic-hap are originated in the actual plugin that is triggered by pimatic-hap. In this case the Shellswitch executes twice.

@mwittig
Copy link
Collaborator

mwittig commented Jul 12, 2016

OK, thanks to the @ modifier there is no error message, but no doubt the code is wrong, from the beginnings, btw. I'll fix it on the v0.9.x branch.

@mwittig mwittig closed this Jul 12, 2016
@michbeck100
Copy link
Contributor Author

is the master branch still active anyway? I guess you should switch master to v0.8.x and v0.9.x to master? i think this should be done with pimatic itself, too.

@mwittig
Copy link
Collaborator

mwittig commented Jul 13, 2016

Right. Either switch branches or possibly rebase master as it is not intended to do further releases von v0.8 anyway.

@mwittig
Copy link
Collaborator

mwittig commented Jul 14, 2016

Actually, your fix has revealed another bug - fixed with d051258

@michbeck100
Copy link
Contributor Author

You're not the only one. I have seen the exact same bug in another plugin already ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShellSwitch executes twice & Sliding back dimmers
2 participants