Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort items in the datahub #815

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Sort items in the datahub #815

merged 3 commits into from
Dec 18, 2023

Conversation

jeremygnoonan
Copy link
Contributor

@jeremygnoonan jeremygnoonan commented Nov 8, 2023

Sorts data hub list:

* Folders come first, sorted

  • Items in folders are sorted
  • Things outside of folders are sorted and included second

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2023

CLA assistant check
All committers have signed the CLA.

@NiklasBr
Copy link
Contributor

Please don't sort folders first, it is unintuitive and breaks expectations.

@jeremygnoonan
Copy link
Contributor Author

@NiklasBr I removed the folder first sorting, and also made it case insensitive to behave like the object tree.

@jeremygnoonan jeremygnoonan changed the base branch from 1.6 to 1.x December 14, 2023 14:36
@herbertroth herbertroth requested a review from mcop1 December 14, 2023 15:37
@mcop1 mcop1 added this to the 1.7.0 milestone Dec 15, 2023
@mcop1
Copy link
Contributor

mcop1 commented Dec 15, 2023

Hello @jeremygnoonan,
thank you for the pr, code works fine.

What do you think about sorting by type too? With different data-hub plugins it would look something like this right now:
image

Personally I would like it a bit more if we sort by plugin type too. But I guess that would go in the same directions as sorting the folders. Any opinions on that? @NiklasBr ?

@mcop1
Copy link
Contributor

mcop1 commented Dec 18, 2023

To keep things short, I created a follow up ticket to sort configurations in the front end (where sorting should really be imo). Feedback is welcome of course -> #826

Thanks again for the pr!

@mcop1 mcop1 merged commit e73fd2e into pimcore:1.x Dec 18, 2023
8 checks passed
@NiklasBr
Copy link
Contributor

Just alphabetical natural sorting IMO is great, everything else is known to cause undue cognitive load.

@jeremygnoonan
Copy link
Contributor Author

Thanks guys hope you had a great holiday!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants