Merge pull request #256 from streeter/ignore-sites-framework

Only import django.contrib.sites if it is required
pinax · Jul 28, 2016 · 5b3ec94 · 5b3ec94
2 parents cb7ccde + b9d9a11
commit 5b3ec94
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/pinax/stripe/hooks.py b/pinax/stripe/hooks.py
@@ -1,8 +1,6 @@
 from django.core.mail import EmailMessage
 from django.template.loader import render_to_string
 
-from django.contrib.sites.models import Site
-
 
 class DefaultHookSet(object):
 
@@ -30,6 +28,9 @@ def trial_period(self, user, plan):
     def send_receipt(self, charge):
         from django.conf import settings
         if not charge.receipt_sent:
+            # Import here to not add a hard dependency on the Sites framework
+            from django.contrib.sites.models import Site
+
             site = Site.objects.get_current()
             protocol = getattr(settings, "DEFAULT_HTTP_PROTOCOL", "http")
             ctx = {

diff --git a/pinax/stripe/tests/hooks.py b/pinax/stripe/tests/hooks.py
@@ -5,8 +5,6 @@
 from django.template.loader import render_to_string
 from django.utils import timezone
 
-from django.contrib.sites.models import Site
-
 from ..hooks import DefaultHookSet
 
 
@@ -34,6 +32,8 @@ def trial_period(self, user, plan):
 
     def send_receipt(self, charge):
         if not charge.receipt_sent:
+            from django.contrib.sites.models import Site
+
             site = Site.objects.get_current()
             protocol = getattr(settings, "DEFAULT_HTTP_PROTOCOL", "http")
             ctx = {