Catch InvalidRequestError thrown by invoices.create

I've been getting "Nothing to invoice for customer" thrown by the create(customer) call, and this small change fixes the error.
pinax · Mar 9, 2017 · 5ffd66a · 5ffd66a
1 parent ec14b69
commit 5ffd66a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/pinax/stripe/actions/invoices.py b/pinax/stripe/actions/invoices.py
@@ -37,8 +37,8 @@ def create_and_pay(customer):
     Returns:
         True, if invoice was created, False if there was an error
     """
-    invoice = create(customer)
     try:
+        invoice = create(customer)
         if invoice.amount_due > 0:
             invoice.pay()
         return True

diff --git a/pinax/stripe/tests/test_actions.py b/pinax/stripe/tests/test_actions.py
@@ -341,6 +341,11 @@ def test_create_and_pay_invalid_request_error(self, CreateMock):
         self.assertFalse(invoices.create_and_pay(Mock()))
         self.assertTrue(invoice.pay.called)
 
+    @patch("stripe.Invoice.create")
+    def test_create_and_pay_invalid_request_error_on_create(self, CreateMock):
+        CreateMock.side_effect = stripe.InvalidRequestError("Bad", "error")
+        self.assertFalse(invoices.create_and_pay(Mock()))
+
 
 class RefundsTests(TestCase):