Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

*: use tikv/client-go/v2 #1205

Merged
merged 5 commits into from
Jun 11, 2021
Merged

*: use tikv/client-go/v2 #1205

merged 5 commits into from
Jun 11, 2021

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Jun 11, 2021

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

We want to use client-go/v2 and remove store/tikv.

Part of pingcap/tidb#22513

wait for pingcap/tidb#25359

What is changed and how it works?

What's Changed:

  • Use tikv/client-go/v2 to replace github.com/pingcap/tidb/store/tikv.
  • Disable some tests temporarily, as the embedded BR in tidb-server cannot work before upgrading.

Check List

Tests

  • Unit test

Release note

  • No release note

Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
@disksing disksing marked this pull request as ready for review June 11, 2021 09:34
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
@disksing disksing changed the title *: use tikv/client-go/v2 [WIP] *: use tikv/client-go/v2 Jun 11, 2021
Signed-off-by: disksing <i@disksing.com>
@disksing disksing changed the title [WIP] *: use tikv/client-go/v2 *: use tikv/client-go/v2 Jun 11, 2021
@disksing
Copy link
Contributor Author

/run-integration_test

@disksing
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Jun 11, 2021
@ti-chi-bot
Copy link
Member

@nolouch: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lonng
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Jun 11, 2021
@disksing
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@disksing: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lonng
Copy link
Contributor

lonng commented Jun 11, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: aacd732

@lonng lonng added this to the v5.1.0 milestone Jun 11, 2021
@ti-chi-bot ti-chi-bot merged commit 74f18bc into pingcap:master Jun 11, 2021
@disksing disksing deleted the client-v2 branch June 11, 2021 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants