Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

lightning: fix parquet parser for decimal type (#1272) #1330

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

glorv
Copy link
Collaborator

@glorv glorv commented Jul 9, 2021

This is an automated cherry-pick of #1272

What problem does this PR solve?

Fix parse parquet file when the corresponding type is decimal with FIXED_LEN_BYTE_ARRAY or BINARY

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

Release note

  • Fix parquet parse when parse decimal type

@ti-chi-bot
Copy link
Member

@glorv: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Jul 9, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Jul 14, 2021
@kennytm
Copy link
Collaborator

kennytm commented Jul 14, 2021

what's the difference between this and #1275 though

@glorv
Copy link
Collaborator Author

glorv commented Jul 14, 2021

what's the difference between this and #1275 though

No different but the target branch. release-5.1-20210709 is created and used by DBaaS. Not sure why they don't depned on release-5.1 directly. 😒

@glorv
Copy link
Collaborator Author

glorv commented Jul 14, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b864b86

@glorv glorv merged commit b82128c into pingcap:release-5.1-20210709 Jul 14, 2021
@glorv glorv deleted the cp-1272 branch July 14, 2021 11:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants