This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Don't log secret of s3. #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
==========================================
+ Coverage 71.32% 71.50% +0.17%
==========================================
Files 48 48
Lines 4997 5025 +28
==========================================
+ Hits 3564 3593 +29
+ Misses 973 971 -2
- Partials 460 461 +1
Continue to review full report at Codecov.
|
Co-authored-by: kennytm <kennytm@gmail.com>
Co-authored-by: kennytm <kennytm@gmail.com>
overvenus
reviewed
May 15, 2020
| @@ -0,0 +1,37 @@ | |||
| package task | |||
pkg/task/common.go
Outdated
| "regexp" | ||
| "strings" | ||
|
|
||
| "github.com/pingcap/log" | ||
| "go.uber.org/zap" | ||
|
|
There was a problem hiding this comment.
Please remove the empty line.
added 2 commits
May 15, 2020 16:44
|
cherry pick to release-3.1 failed |
|
cherry pick to release-4.0 in PR #293 |
YuJuncen
added a commit
that referenced
this pull request
May 18, 2020
* backup: don't log secret of s3. * br_s3: always print log. * *: remove query string on logging arguments. * br_s3: reset BR_LOG_TO_TERM on fail. * Apply suggestions from code review Co-authored-by: kennytm <kennytm@gmail.com> * Apply suggestions from code review Co-authored-by: kennytm <kennytm@gmail.com> * *: remove query string on logging arguments. Co-authored-by: Hillium <maruruku@stu.csust.edu.cn> Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com> Co-authored-by: kennytm <kennytm@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix bug hunting #71
What is changed and how it works?
I change the line that logging the secret information:
br/pkg/backup/client.go
Line 763 in 00fe08c
Check List
Tests
Code changes
LogArgumentsfromutilstotask).Release Note