Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

storage: S3 test refactoring and fix some bugs #548

Merged
merged 6 commits into from
Oct 9, 2020
Merged

storage: S3 test refactoring and fix some bugs #548

merged 6 commits into from
Oct 9, 2020

Commits on Oct 4, 2020

  1. storage: replace s3Handlers by the standard s3iface.S3API interface

    @kennytm
    kennytm committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    abe43fb View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. storage: publish RangeInfo for testing

    @kennytm
    kennytm committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    4da5533 View commit details
    Browse the repository at this point in the history

  2. storage: use gomock instead of mockS3Handlers for proper mocking 

    this requires s3_test to be placed into a separate storage_test package
to avoid circular dependency.

this makes the `checkS3` hack not usable. instead, we introduced a new
option struct to the constructor to disable to the check.
    @kennytm
    kennytm committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    b691587 View commit details
    Browse the repository at this point in the history

  3. storage/s3: fix FileExists always return true, nil on non-AWS error

    @kennytm
    kennytm committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    acc5050 View commit details
    Browse the repository at this point in the history

  4. storage/s3: do not use ReadFull to implement Read

    @kennytm
    kennytm committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    62f230f View commit details
    Browse the repository at this point in the history

  5. storage/s3: fix incorrect usage of NextMarker in WalkDir

    @kennytm
    kennytm committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    17f0da8 View commit details
    Browse the repository at this point in the history