This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 102
backup/: retry for read index not ready and proposal in merging mode #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lichunzhu
changed the title
retry for read index not ready and proposal in merging mode
backup/: retry for read index not ready and proposal in merging mode
Nov 25, 2020
lichunzhu
force-pushed
the
retryForSomeTiKVError
branch
from
November 26, 2020 02:45
9e22cbf
to
879f253
Compare
overvenus
reviewed
Nov 27, 2020
Comment on lines
+714
to
+715
regionErr.ReadIndexNotReady != nil || | ||
regionErr.ProposalInMergingMode != nil) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test.
/rebuild |
kennytm
reviewed
Nov 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
overvenus
approved these changes
Nov 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
approved these changes
Nov 27, 2020
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Nov 27, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #626 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#606
What is changed and how it works?
Retry for newly added read index not ready and proposal in merging mode errors.
Check List
Tests
Related changes
Release Note