Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

backup/: retry for read index not ready and proposal in merging mode #615

Merged
merged 7 commits into from
Nov 27, 2020

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

#606

What is changed and how it works?

Retry for newly added read index not ready and proposal in merging mode errors.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • No release note

@lichunzhu lichunzhu changed the title retry for read index not ready and proposal in merging mode backup/: retry for read index not ready and proposal in merging mode Nov 25, 2020
@lichunzhu lichunzhu marked this pull request as ready for review November 26, 2020 02:46
@lichunzhu lichunzhu added this to the v4.0.9 milestone Nov 26, 2020
Comment on lines +714 to +715
regionErr.ReadIndexNotReady != nil ||
regionErr.ProposalInMergingMode != nil) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test.

@lichunzhu
Copy link
Contributor Author

/rebuild

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Nov 27, 2020
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGTM1 label Nov 27, 2020
@ti-srebot ti-srebot added the status/LGT2 LGTM2 label Nov 27, 2020
@lichunzhu lichunzhu merged commit f982557 into pingcap:master Nov 27, 2020
@lichunzhu lichunzhu deleted the retryForSomeTiKVError branch November 27, 2020 07:16
ti-srebot pushed a commit to ti-srebot/br that referenced this pull request Nov 27, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #626

ti-srebot added a commit that referenced this pull request Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants