Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

pd: add check when leader is empty #636

Merged
merged 3 commits into from
Dec 8, 2020
Merged

pd: add check when leader is empty #636

merged 3 commits into from
Dec 8, 2020

Conversation

3pointer
Copy link
Collaborator

@3pointer 3pointer commented Dec 4, 2020

What problem does this PR solve?

try to resolve #634.

What is changed and how it works?

add check when scanRegions return empty leader but have peer.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Note

  • No release note.

overvenus
overvenus reviewed Dec 4, 2020
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Dec 4, 2020
@kennytm
Copy link
Collaborator

kennytm commented Dec 4, 2020

/run-integration-tests

https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/4100/pipeline

[2020-12-04T12:04:14.338Z] Error: start ts:421287269735858179 is greater than resolved ts:0: [BR:Restore:ErrRestoreResolvedTsConstrain]resolved ts constrain violation

kennytm
kennytm approved these changes Dec 7, 2020
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Dec 7, 2020
@kennytm
Copy link
Collaborator

kennytm commented Dec 7, 2020

/merge

@3pointer
Copy link
Collaborator Author

3pointer commented Dec 7, 2020

/run-integration-test

@3pointer
Copy link
Collaborator Author

3pointer commented Dec 8, 2020 

[2020-12-04T12:04:14.338Z] Error: start ts:421287269735858179 is greater than resolved ts:0: [BR:Restore:ErrRestoreResolvedTsConstrain]resolved ts constrain violation

This error means when BR try to read log backup meta file. it reads nothing. and in many cases it's means CDC didn't flush meta file. maybe we should wait more time.

@3pointer 3pointer merged commit 6cd0c9c into pingcap:master Dec 8, 2020
ti-srebot pushed a commit to ti-srebot/br that referenced this pull request Dec 8, 2020
@3pointer @ti-srebot
cherry pick pingcap#636 to release-4.0
6c6a89d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 8, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #637

@3pointer 3pointer mentioned this pull request Dec 8, 2020
Open
3pointer added a commit that referenced this pull request Dec 14, 2020
@ti-srebot @3pointer
cherry pick #636 to release-4.0 (#637)
8364c7a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: 3pointer <luancheng@pingcap.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@overvenus overvenus overvenus left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@kennytm kennytm kennytm approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 status/LGT2 LGTM2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore failed due to invalid store id 0
4 participants
@3pointer @kennytm @ti-srebot @overvenus