This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 102
restore: fast fail when backup table's cluster index option is not consistent #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fastFailClusterIndex
kennytm
reviewed
Jan 8, 2021
kennytm
reviewed
Jan 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please provide a test case. rest LGTM.
3pointer
reviewed
Jan 11, 2021
/run-all-tests |
kennytm
reviewed
Jan 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3pointer
approved these changes
Jan 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
approved these changes
Jan 11, 2021
3pointer
added
needs-cherry-pick-release-4.0
and removed
needs-cherry-pick-release-4.0
labels
Jan 19, 2021
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Jan 19, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #706 |
3 tasks
This was referenced May 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
If we backup table with cluster index option A, restore table with cluster index option B. If A != B, the table data might be corrupted.
What is changed and how it works?
Check table's info with existed tables before exec DDL and restore tables.
Check List
Tests
tidb_enable_clustered_index=OFF
.tidb_enable_clustered_index=ON
.Code changes
Release Note