This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 102
gcs: compatible with old gcs bug (#677) #688
Merged
kennytm
merged 4 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-3de76b2ec3f2
Jan 11, 2021
Merged
gcs: compatible with old gcs bug (#677) #688
kennytm
merged 4 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-3de76b2ec3f2
Jan 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
1 similar comment
/run-all-tests |
|
/run-all-tests |
3pointer
force-pushed
the
release-4.0-3de76b2ec3f2
branch
from
January 11, 2021 11:44
9fd8895
to
b96a8dd
Compare
/run-all-tests |
LGTM |
Lgtm |
kennytm
approved these changes
Jan 11, 2021
/merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #677 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In br repo: git pr 688
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
solve #675
What is changed and how it works?
for case 1: add a check before Read & Write meta file, decide which prefix to use.
for case 2: check whether sst file is in Prefix(after #647) or in PrefixSlash(before #647), adjust proper prefix for TiKV request.
Check List
Tests
Related changes
Release Note