Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

pause-task or stop-task may be blocked for load unit #1262

Closed
csuzhangxc opened this issue Nov 2, 2020 · 2 comments · Fixed by #1265
Closed

pause-task or stop-task may be blocked for load unit #1262

csuzhangxc opened this issue Nov 2, 2020 · 2 comments · Fixed by #1265
Assignees
@csuzhangxc
Labels
severity/major type/bug This issue is a bug report
Milestone
v2.0.1

Comments

@csuzhangxc
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.

    pause-task or stop-task

  2. What did you expect to see?

    the task becomes paused or stopped.

  3. What did you see instead?

    the task still showing running but no more data loaded into downstream.

  4. Versions of the cluster

    • DM version (run dmctl -V or dm-worker -V or dm-master -V):

      v2.0.0

some useful goroutines:
goroutine_debug_2_2020-11-02.txt
@csuzhangxc csuzhangxc added type/bug This issue is a bug report severity/major labels Nov 2, 2020
@csuzhangxc csuzhangxc added this to the v2.0.1 milestone Nov 2, 2020
@csuzhangxc csuzhangxc self-assigned this Nov 2, 2020
@csuzhangxc
Copy link
Member Author

root cause:

  • jobQueue becomes full
  • the sender still trying to send
  • the receiver exits because encountered errors

then the sender blocked

This was referenced Nov 3, 2020
Merged
Closed
@ti-srebot ti-srebot mentioned this issue Nov 4, 2020
Merged
@csuzhangxc csuzhangxc reopened this Nov 5, 2020
@csuzhangxc
Copy link
Member Author

more scenarios will cause block, see goroutines bellow (for b58e603)

goroutine_debug_2_2020-11-05.txt

@csuzhangxc csuzhangxc mentioned this issue Nov 5, 2020
Merged
@ti-srebot ti-srebot mentioned this issue Nov 6, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@csuzhangxc csuzhangxc

Labels
severity/major type/bug This issue is a bug report
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging a pull request may close this issue.

fix: do not block in load unit for stop/pause task csuzhangxc/dm
1 participant
@csuzhangxc