Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

fix: always wait for the sender to exit in the receiver for load unit (#1276) #1277

Merged
merged 1 commit into from
Nov 6, 2020
Merged

fix: always wait for the sender to exit in the receiver for load unit (#1276) #1277

merged 1 commit into from
Nov 6, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1276 to release-2.0

What problem does this PR solve?

fix part2 of #1262, the scenario:

  1. worker-A reported error via runFatalChan
  2. cancel the context
  3. chan received in worker-B exit
  4. chan sender in worker-B blocked

What is changed and how it works?

always wait for the sender to exit in the receiver for load unit

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@csuzhangxc @ti-srebot
cherry pick pingcap#1276 to release-2.0
6d5bd52 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 6, 2020
Merged
@ti-srebot ti-srebot added first-time-contributor needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Nov 6, 2020
csuzhangxc
csuzhangxc approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716
Copy link
Collaborator

/run-all-tests

database driver error" RawCause:"dial tcp 127.0.0.1:4000: connect: connection refused"

@lance6716
Copy link
Collaborator

/run-all-tests

@csuzhangxc csuzhangxc merged commit 954b4c3 into pingcap:release-2.0 Nov 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

@WangXiangUSTC WangXiangUSTC Awaiting requested review from WangXiangUSTC

Assignees
No one assigned
Labels
first-time-contributor needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @lance6716 @csuzhangxc