Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

remove mydumper dependence and use a Go implementation directly #395

Closed
siddontang opened this issue Dec 3, 2019 · 2 comments
Closed

remove mydumper dependence and use a Go implementation directly #395

siddontang opened this issue Dec 3, 2019 · 2 comments
Assignees
Labels
type/feature-request This issue is a feature request

Comments

@siddontang
Copy link
Member

siddontang commented Dec 3, 2019

Feature Request

Is your feature request related to a problem? Please describe:

Now we must install mydumper explicitly to let DM to support full backup, it is not easy to operate.

why not let DM support dump directly?

Describe the feature you'd like:

Refer to https://github.com/xelabs/go-mydumper

Seem we can use the above Go lib directly, maybe the only risk is the stability of the lib. But the dump logic is easy, and I think we can hold the lib easily.

Describe alternatives you've considered:
Maybe reinvent the wheel, it is not easy work.

Teachability, Documentation, Adoption, Migration Strategy:
No

@siddontang siddontang added the type/feature-request This issue is a feature request label Dec 3, 2019
@siddontang siddontang changed the title remove mydumper dependence remove mydumper dependence and use a Go implementation directly Dec 3, 2019
@kennytm
Copy link
Contributor

kennytm commented Dec 3, 2019

Note that go-mydumper is GPL'ed so we can't use that project as a library. We could still bundle it as a separate executable and run it as a sub process but there won't be much advantage compared with the current mydumper in terms of integration.

@csuzhangxc
Copy link
Member

already replaced with dumpling in #540.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature-request This issue is a feature request
Projects
None yet
Development

No branches or pull requests

4 participants