This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
dump/: integrate dumpling #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lichunzhu
added
priority/normal
|
/run-all-tests tidb=release-3.0 |
lichunzhu
added
status/PTAL
|
/run-all-tests tidb=release-3.0 |
csuzhangxc
reviewed
Mar 17, 2020
csuzhangxc
removed
the
status/PTAL
|
pingcap/dumpling#51 |
Codecov Report
@@ Coverage Diff @@
## master #540 +/- ##
===========================================
Coverage 57.4546% 57.4546%
===========================================
Files 183 183
Lines 19337 19337
===========================================
Hits 11110 11110
Misses 7118 7118
Partials 1109 1109 |
dumpling/dumpling.go
Outdated
| } else { | ||
| select { | ||
| case <-ctx.Done(): | ||
| isCanceled = true |
There was a problem hiding this comment.
what is the isCanceled used for?
dumpling/dumpling.go
Outdated
| dumpConfig.Where = cfg.Where | ||
| } | ||
|
|
||
| var ret []string |
There was a problem hiding this comment.
ret is used to save some unsupported arguments? how about adding a comment
dumpling/dumpling.go
Outdated
|
|
||
| extraArgs := strings.Fields(cfg.ExtraArgs) | ||
| if len(extraArgs) > 0 { | ||
| ret = append(ret, ParseArgLikeBash(extraArgs)...) |
There was a problem hiding this comment.
do we need to parse the extra-args, like some config in the integration test, the user may set extra-args: "--statement-size=100", it may cause incompatible problem
WangXiangUSTC
added
status/LGT2
WangXiangUSTC
approved these changes
Mar 18, 2020
lichunzhu
added a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Dump sql using dumpling. It's not easy to use for users because they need to download a mydumper binary file.
lichunzhu
added a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Dump sql using dumpling. It's not easy to use for users because they need to download a mydumper binary file.
lichunzhu
added a commit
to lichunzhu/dm
that referenced
this pull request
Apr 7, 2020
Dump sql using dumpling. It's not easy to use for users because they need to download a mydumper binary file.
This was referenced Apr 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#526
What is changed and how it works?
Dump sql using dumpling. It's not easy to use for users because they need to download a mydumper binary file.
Check List
Tests
Code changes
Side effects
Related changes
dm/dm-ansible