Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: auto discover ANSI_QUOTES #889 #1005

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Conversation

lance6716
Copy link
Collaborator

manually cherry-pick #889


What problem does this PR solve?

close #878

What is changed and how it works?

still need user specified ANSI_QUOTES:

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release branch

@CLAassistant
Copy link

CLAassistant commented Sep 8, 2020

CLA assistant check
All committers have signed the CLA.

@lance6716 lance6716 changed the base branch from master to release-2.0 September 8, 2020 06:48
@lance6716 lance6716 added the type/cherry-pick This PR is just a cherry-pick (backport) label Sep 8, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Sep 8, 2020
@csuzhangxc csuzhangxc added the status/LGT1 One reviewer already commented LGTM label Sep 8, 2020
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Sep 9, 2020
@lance6716 lance6716 merged commit 02f7846 into pingcap:release-2.0 Sep 9, 2020
@lance6716 lance6716 deleted the cp889 branch July 6, 2021 02:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uniform handle for ansi-quotes and ANSI_QUOTES sql_mode in session for task config
4 participants