Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: refine dashboard #101

Merged
merged 9 commits into from
Apr 16, 2019
Merged

*: refine dashboard #101

merged 9 commits into from
Apr 16, 2019

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Apr 4, 2019 •
edited
Loading

What problem does this PR solve?

refine the dashboard

What is changed and how it works?

  • only show instances for the selected task
  • add the description for metrics
  • add an overview monitoring for the task
    • see screenshot below
  • add a board for the status of the instance
    • see screenshot below

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • run some tasks
    • observe the dashboard

Related changes

  • Need to update the documentation
  • Need to update the dm/dm-ansible

verview monitoring for the task

board for the status of the instance

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated status/WIP This PR is still work in progress type/enhancement Performance improvement or refactoring labels Apr 4, 2019
@csuzhangxc csuzhangxc added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels Apr 9, 2019
@csuzhangxc
Copy link
Member Author

@GregoryIan @amyangfei PTAL

@IANTHEREAL
Copy link
Collaborator

IANTHEREAL commented Apr 15, 2019 •
edited
Loading

should we display instance name in panel for an overview monitoring for the task and the status of the instance?

@IANTHEREAL
Copy link
Collaborator

LGTM

@csuzhangxc
Copy link
Member Author

csuzhangxc commented Apr 15, 2019 •
edited
Loading

should we display instance name in panel for an overview monitoring for the task and the status of the instance?

you can see the instance name in the drop-down list of templating in the upper-left corner.

amyangfei
amyangfei reviewed Apr 16, 2019
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Apr 16, 2019
@csuzhangxc csuzhangxc merged commit 0dae456 into pingcap:master Apr 16, 2019
@csuzhangxc csuzhangxc deleted the refine-dashboard branch April 16, 2019 07:35
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@csuzhangxc
*: refine dashboard (pingcap#101)
922ca06
@csuzhangxc csuzhangxc removed the needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated label Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyangfei amyangfei amyangfei left review comments

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/enhancement Performance improvement or refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csuzhangxc @IANTHEREAL @amyangfei