Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

tls: minor fix on http api (#1008) #1036

Merged
merged 2 commits into from
Sep 15, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1008 to release-2.0


What problem does this PR solve?

when setting cert-allowed-cn, will get an error when sending an HTTP request with GRPC gateway, the error log looks like:

transport: authentication handshake failed: client certificate authentication failed. The Common Na
me from the client certificate [] was not found in the configuration cluster-verify-cn with value: [dm]`

What is changed and how it works?

fix it

Check List

Tests

  • Integration test
  • Manual test

@ti-srebot ti-srebot added type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Sep 15, 2020
@lance6716
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Sep 15, 2020
@csuzhangxc
Copy link
Member

/run-all-tests

"rpc addr 127.0.0.1:8262 check alive timeout"

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc merged commit 63a8eb0 into pingcap:release-2.0 Sep 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants