Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

tracker: fetch ref table at CREATE LIKE and more #1105

Merged
merged 17 commits into from
Sep 27, 2020
Merged

tracker: fetch ref table at CREATE LIKE and more #1105

merged 17 commits into from
Sep 27, 2020

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Sep 25, 2020 •
edited by GMHDBJD
Loading

What problem does this PR solve?

close #1099

What is changed and how it works?

FetchDDLTableNames now return all found tableNames, and some variables in trackDDL now become int represent how many tableName should used.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix labels Sep 25, 2020
@lance6716
Copy link
Collaborator Author

lance6716 commented Sep 25, 2020 •
edited
Loading

https://docs.pingcap.com/tidb/stable/views

should we support sync CREATE VIEW DDL now? we drop it inbuiltInSkipDDLs now

@csuzhangxc
Copy link
Member

https://docs.pingcap.com/tidb/stable/views

should we support sync CREATE VIEW DDL now? we drop it inbuiltInSkipDDLs now

I think we need to support it because it used by a large number of users.

@lance6716 lance6716 added status/WIP This PR is still work in progress needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Sep 25, 2020
@lance6716 lance6716 removed the status/WIP This PR is still work in progress label Sep 25, 2020
@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716 lance6716 added the status/WIP This PR is still work in progress label Sep 27, 2020
@lance6716 lance6716 removed the status/WIP This PR is still work in progress label Sep 27, 2020
csuzhangxc
csuzhangxc reviewed Sep 27, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 27, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Sep 27, 2020
GMHDBJD
GMHDBJD approved these changes Sep 27, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Sep 27, 2020
@lance6716 lance6716 merged commit aef0f37 into pingcap:master Sep 27, 2020
@ti-srebot ti-srebot mentioned this pull request Sep 27, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1108

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Sep 27, 2020
csuzhangxc pushed a commit that referenced this pull request Sep 28, 2020
@ti-srebot @lance6716
tracker: fetch ref table at CREATE LIKE and more (#1105) (#1108)
0cecb73 
Co-authored-by: lance6716 <lance6716@gmail.com>
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Oct 27, 2020
@lance6716 lance6716 removed the needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated label Oct 27, 2020
@lance6716 lance6716 mentioned this pull request Nov 25, 2020
Closed
lance6716 added a commit to lance6716/dm that referenced this pull request Dec 10, 2020
@lance6716
*: add test for pingcap#1329 and revert VIEW support for pingcap#1105
f53dd60
@lance6716 lance6716 mentioned this pull request Dec 10, 2020
Merged
@ti-srebot ti-srebot mentioned this pull request Dec 17, 2020
Merged
@lance6716 lance6716 deleted the fetch-more-table branch July 6, 2021 02:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Can't track "create table t1 like t2"
4 participants
@lance6716 @csuzhangxc @ti-srebot @GMHDBJD