Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

loader: fix bug that SQL Mode didn't take effect #1134

Merged
merged 4 commits into from
Oct 12, 2020
Merged

loader: fix bug that SQL Mode didn't take effect #1134

merged 4 commits into from
Oct 12, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

fix bug that loader didn't use SQL Mode when create database connections, this bug is not revealed because all_mode has manually set SQL Mode related config

What is changed and how it works?

if to database doesn't have a sql_mode item, we use SQL Mode discovered by dumpling's Init.

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix labels Oct 10, 2020
@lance6716
Copy link
Collaborator Author

/run-all-tests

csuzhangxc
csuzhangxc reviewed Oct 10, 2020
View reviewed changes
loader/loader.go Outdated Show resolved Hide resolved
csuzhangxc
csuzhangxc reviewed Oct 10, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Oct 10, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Oct 10, 2020
GMHDBJD
GMHDBJD approved these changes Oct 12, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 merged commit 49a2969 into pingcap:master Oct 12, 2020
@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Oct 12, 2020
@lance6716 lance6716 deleted the fix-loader-sql-mode branch October 12, 2020 01:52
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Oct 12, 2020
@lance6716 @ti-srebot
cherry pick pingcap#1134 to release-2.0
380ea51 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 12, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1137

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Oct 12, 2020
csuzhangxc pushed a commit that referenced this pull request Oct 12, 2020
@ti-srebot @lance6716
cherry pick #1134 to release-2.0 (#1137)
7925795 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: lance6716 <lance6716@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @ti-srebot @csuzhangxc @GMHDBJD