Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

worker: create subtask for paused stage (#1165) #1183

Merged
merged 1 commit into from
Oct 19, 2020
Merged

worker: create subtask for paused stage (#1165) #1183

merged 1 commit into from
Oct 19, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1165 to release-2.0

What problem does this PR solve?

close #1090

What is changed and how it works?

  • create subtask even for paused stage task
  • refine some logs

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

@csuzhangxc @ti-srebot
cherry pick pingcap#1165 to release-2.0
9bab3a3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 19, 2020
Merged
@ti-srebot ti-srebot added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Oct 19, 2020
@lance6716
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Oct 19, 2020
csuzhangxc
csuzhangxc approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Oct 19, 2020
@csuzhangxc csuzhangxc merged commit 14d6aad into pingcap:release-2.0 Oct 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
first-time-contributor priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @lance6716 @csuzhangxc