Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dashboard: change dashboard name #120

Merged
merged 2 commits into from
Apr 19, 2019
Merged

dashboard: change dashboard name #120

merged 2 commits into from
Apr 19, 2019

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Apr 19, 2019 •
edited
Loading

What problem does this PR solve?

now we have two dashboards, then change DM to DM-task is better.

What is changed and how it works?

  • change dashboard name from DM to DM-task.
  • also, change name from DM-instances to DM-instance

Check List

Tests

  • No code

Related changes

  • Need to update the documentation
  • Need to update the dm/dm-ansible

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/compatibility Backward compatibility will be broken after this PR merged labels Apr 19, 2019
@IANTHEREAL
Copy link
Collaborator

LGTM

@IANTHEREAL IANTHEREAL added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Apr 19, 2019
amyangfei
amyangfei approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Apr 19, 2019
@csuzhangxc csuzhangxc merged commit fd2588a into pingcap:master Apr 19, 2019
@csuzhangxc csuzhangxc deleted the refine-dashboard branch April 19, 2019 09:36
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@csuzhangxc
dashboard: change dashboard name (pingcap#120)
75197c1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyangfei amyangfei amyangfei approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/compatibility Backward compatibility will be broken after this PR merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csuzhangxc @IANTHEREAL @amyangfei