Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

relay: support relay log in v2.0 (#1272) #1316

Merged
merged 3 commits into from
Dec 21, 2020
Merged

relay: support relay log in v2.0 (#1272) #1316

merged 3 commits into from
Dec 21, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1272 to release-2.0

What problem does this PR solve?

part of #1234

What is changed and how it works?

  • support TLS in relay
  • support gtid in relay

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

@GMHDBJD @ti-srebot
cherry pick pingcap#1272 to release-2.0
89fbb0b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 30, 2020
Merged
2 tasks
@ti-srebot ti-srebot added needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes first-time-contributor type/cherry-pick This PR is just a cherry-pick (backport) labels Nov 30, 2020
@GMHDBJD GMHDBJD added status/DNM Do not merge, test is failing or blocked by another PR and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Nov 30, 2020
@lance6716 lance6716 mentioned this pull request Dec 10, 2020
Merged
@GMHDBJD GMHDBJD mentioned this pull request Dec 18, 2020
Merged
7 tasks
@GMHDBJD GMHDBJD added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/DNM Do not merge, test is failing or blocked by another PR labels Dec 18, 2020
GMHDBJD
GMHDBJD reviewed Dec 18, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Dec 18, 2020
lance6716
lance6716 approved these changes Dec 18, 2020
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716
Copy link
Collaborator

/run-all-tests

[2020-12-18T10:44:16.411Z] [2020/12/18 18:15:42.366 +08:00] [ERROR] [db.go:175] ["execute statements failed after retry"] [task=test] [unit=load] ["worker ID"=1] [queries="[USE many_tables_db; INSERT INTO t356 (i,j) VALUES\n(1,10001),\n(1,10011),\n(2,20002),\n(2,20012); UPDATE dm_meta.test_loader_checkpoint SET offset=109 WHERE id ='mysql-replica-01' AND filename='many_tables_db.t356.0.sql';]"] [arguments="[]"] [error="[code=10006:class=database:scope=not-set:level=high], Message: execute statement failed: begin, RawCause: invalid connection"]

forget to write a error checker for many_tables

@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Dec 21, 2020

/run-all-tests

@lance6716 lance6716 merged commit 8d8ffc1 into pingcap:release-2.0 Dec 21, 2020
@ti-srebot ti-srebot mentioned this pull request Dec 25, 2020
Merged
7 tasks
@lance6716 lance6716 added already-update-docs The docs related to this PR already updated. Add this label once the docs are updated and removed needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
already-update-docs The docs related to this PR already updated. Add this label once the docs are updated first-time-contributor needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @lance6716 @GMHDBJD @csuzhangxc