Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

parser: split ALTER TABLE ADD COLUMN #1340

Merged
merged 5 commits into from
Dec 17, 2020
Merged

parser: split ALTER TABLE ADD COLUMN #1340

merged 5 commits into from
Dec 17, 2020

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Dec 15, 2020 •
edited
Loading

What problem does this PR solve?

close #1339

What is changed and how it works?

split it

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

@lance6716 lance6716 added status/PTAL This PR is ready for review. Add this label back after committing new changes needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer labels Dec 16, 2020
@lance6716 lance6716 added this to the v2.0.1 milestone Dec 17, 2020
csuzhangxc
csuzhangxc reviewed Dec 17, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

pkg/parser/common.go Show resolved Hide resolved
csuzhangxc
csuzhangxc reviewed Dec 17, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Dec 17, 2020
GMHDBJD
GMHDBJD approved these changes Dec 17, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716
Copy link
Collaborator Author

now the slowest test case is handle_error, about 12min

@lance6716 lance6716 merged commit 4ebd3b5 into pingcap:master Dec 17, 2020
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Dec 17, 2020
@lance6716 @ti-srebot
cherry pick pingcap#1340 to release-2.0
a51182b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 17, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1345

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Dec 17, 2020
csuzhangxc pushed a commit that referenced this pull request Dec 18, 2020
@ti-srebot @lance6716
parser: split ALTER TABLE ADD COLUMN (#1340) (#1345)
ef88545 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: lance6716 <lance6716@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging this pull request may close these issues.

should split DDL for ADD COLUMN (c1 int, c2 int)
4 participants
@lance6716 @ti-srebot @csuzhangxc @GMHDBJD