Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

bug-fix: no need to check gtid of Mariadb (#1335) #1344

Merged
merged 2 commits into from
Dec 21, 2020
Merged

bug-fix: no need to check gtid of Mariadb (#1335) #1344

merged 2 commits into from
Dec 21, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1335 to release-2.0

What problem does this PR solve?

close #1319

What is changed and how it works?

  • fix gitd check of Mariadb
  • better incompatible ddl error message
  • test for auto sql_mode
    TODO:
    add mariadb test for integration test or chaos test

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)
    deploy mariadb locally and run integration test

@GMHDBJD @ti-srebot
cherry pick pingcap#1335 to release-2.0
8e63bb0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 17, 2020
Merged
@ti-srebot ti-srebot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Dec 17, 2020
@lance6716
Copy link
Collaborator

CI wanting for relay log

GMHDBJD
GMHDBJD approved these changes Dec 21, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD merged commit 5dd474f into pingcap:release-2.0 Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@csuzhangxc csuzhangxc Awaiting requested review from csuzhangxc

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @lance6716 @GMHDBJD