This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
streamer: add heartbeat for local streamer #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
added
needs-cherry-pick-release-2.0
|
PTAL @3pointer @lichunzhu |
3pointer
reviewed
Jan 27, 2021
pkg/streamer/streamer.go
Outdated
| select { | ||
| case <-heartbeatTicker.C: |
There was a problem hiding this comment.
<- time.After(heartbeatInterval)
lichunzhu
added
status/LGT1
amyangfei
added
status/LGT2
|
/merge |
|
@lance6716 Oops! This PR requires at least 2 LGTMs to merge. The current number of |
ti-srebot
pushed a commit
to ti-srebot/dm
that referenced
this pull request
Jan 28, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-2.0 in PR #1406 |
ti-srebot
added
already-cherry-pick-2.0
lance6716
pushed a commit
that referenced
this pull request
Jan 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
currently relay will ignore heartbeat event before writing to relay logs. so when relay enabled, there's no heartbeat event which causes syncer can't advance its checkpoint when upstream is idle.
What is changed and how it works?
peroidically send heartbeat event
Check List
Tests
Code changes
Side effects
Related changes