Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

binlog, relay: support binlog sequence number larger than 999999 (#1476) #1503

Merged
merged 2 commits into from
Mar 12, 2021

Conversation

ti-srebot
Copy link

@ti-srebot ti-srebot commented Mar 11, 2021

cherry-pick #1476 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In dm repo:
git pr https://github.com/pingcap/dm/pull/1503

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/dm.git pr/1503:release-2.0-fbb6b525de07

What problem does this PR solve?

close #1475

What is changed and how it works?

compare by numeric logic, not byte order

Check List

Tests

  • integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated type/cherry-pick This PR is just a cherry-pick (backport) labels Mar 11, 2021
@ti-srebot ti-srebot requested a review from GMHDBJD March 11, 2021 11:10
@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Mar 12, 2021

/lgtm

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Mar 12, 2021
@lance6716
Copy link
Collaborator

/lgtm

@ti-srebot ti-srebot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Mar 12, 2021
@lance6716 lance6716 merged commit f8d64fd into pingcap:release-2.0 Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants