-
Notifications
You must be signed in to change notification settings - Fork 188
streamer: fix duplicate event when reparse relay using GTID #1525
Conversation
/cc @GMHDBJD @lichunzhu |
/run-all-tests |
/run-compatibility-test |
/auto-cc |
Will sync unit get duplicate events? (like gtid_event, table map event, rows event) |
Yes, currently we rely on safe mode. I added a todo of changing the behaviour of sending binlog to "sending DML after see XID". Do you think we should do it now? |
I think we may simply return both currentGTID and latestPos for parseFile or save latest gtid now. Otherwise, if safemode has been closed, we may have duplicate data. Or if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3ed9b0a
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-2.0 in PR #1532 |
What problem does this PR solve?
part of #1524
What is changed and how it works?
when DM uses GTID and needs to return a reparse location, return last XID location so that
replaceWithHeartbeat
will be correctly calculatedCheck List
Tests
Code changes
Side effects
Related changes