Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

worker: enable relay and handling subtask on demand (#1508) #1527

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

ti-srebot
Copy link

@ti-srebot ti-srebot commented Mar 23, 2021

cherry-pick #1508 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In dm repo:
git pr https://github.com/pingcap/dm/pull/1527

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/dm.git pr/1527:release-2.0-33c2a59befbb

What problem does this PR solve?

call EnableRelay when source config enables relay, and call EnableHandleSubTask when receive a source bound. In future we will call EnableRelay by watching another prefix in etcd

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release branch

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Mar 23, 2021
@lance6716
Copy link
Collaborator

/run-all-tests

@lance6716
Copy link
Collaborator

/run-compatibility-tests

@lance6716
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Mar 24, 2021
@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Mar 24, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Mar 24, 2021
@lance6716
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 97a547e

@ti-chi-bot ti-chi-bot merged commit 3407f19 into pingcap:release-2.0 Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
first-time-contributor size/XXL status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants