Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dmctl, master: refine source behaviour in operate-source #1587

Merged
merged 4 commits into from
Apr 20, 2021
Merged

dmctl, master: refine source behaviour in operate-source #1587

merged 4 commits into from
Apr 20, 2021

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Apr 12, 2021 •
edited
Loading

What problem does this PR solve?

close #1561 close #1530

What is changed and how it works?

Check List

Tests

  • Integration test

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@lance6716
Copy link
Collaborator Author

/hold

@ti-chi-bot ti-chi-bot added size/M and removed size/S labels Apr 12, 2021
@lance6716
Copy link
Collaborator Author

/unhold

@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Apr 12, 2021
@lance6716 lance6716 added this to the v2.0.3 milestone Apr 12, 2021
@lance6716 lance6716 linked an issue Apr 14, 2021 that may be closed by this pull request
operate-source show didn't respect -s #1530
Closed
@lichunzhu
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Apr 16, 2021
@lance6716
Copy link
Collaborator Author

/cc @GMHDBJD

GMHDBJD
GMHDBJD approved these changes Apr 20, 2021
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Apr 20, 2021
@lance6716
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0b658ab

@ti-chi-bot ti-chi-bot merged commit c488033 into pingcap:master Apr 20, 2021
@lance6716
Copy link
Collaborator Author

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Apr 20, 2021
@lance6716 @ti-srebot
cherry pick pingcap#1587 to release-2.0
8af6a2f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1611

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Apr 20, 2021
ti-chi-bot pushed a commit that referenced this pull request Apr 20, 2021
@ti-srebot
dmctl, master: refine source behaviour in operate-source (#1587) (#…
48ceea6 
…1611)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/M status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Milestone
v2.0.3
Development

Successfully merging this pull request may close these issues.

can't operate-source stop <config-file> a source that is inaccessible operate-source show didn't respect -s
5 participants
@lance6716 @lichunzhu @ti-chi-bot @ti-srebot @GMHDBJD