Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

scheduler: close workers grpc connections timely (#1639) #1643

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

ti-srebot
Copy link

@ti-srebot ti-srebot commented Apr 29, 2021

cherry-pick #1639 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In dm repo:
git pr https://github.com/pingcap/dm/pull/1643

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/dm.git pr/1643:release-2.0-c88ea874ef83

What problem does this PR solve?

part 2 of #1636
dm-master didn't close grpc connections before it close scheduler.

What is changed and how it works?

Close scheduler.workers grpc connections when scheduler fails to start or trying to Close.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated severity/critical size/M status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Apr 29, 2021
@lichunzhu
Copy link
Contributor

/label require-LGT-1

@ti-chi-bot
Copy link
Member

@lichunzhu: The label(s) require-lgt-1 cannot be applied. These labels are supported: Hacktoberfest, TiDB-5.0, already-cherry-pick-1.0, already-cherry-pick-2.0, already-update-dm-ansible, already-update-docs, already-update-release-note, dependencies, good first issue, help wanted, high-performance, hptc, javascript, needs-cherry-pick-1.0, needs-cherry-pick-2.0, needs-update-dm-ansible, needs-update-docs, needs-update-release-note, question, release-track.

In response to this:

/label require-LGT-1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lichunzhu lichunzhu added the require-LGT1 for small PR, LGT1 is enough label Apr 29, 2021
@lichunzhu
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Apr 29, 2021
@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 136784e

@ti-chi-bot ti-chi-bot merged commit 6daf5fa into pingcap:release-2.0 Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
first-time-contributor needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated require-LGT1 for small PR, LGT1 is enough severity/critical size/M status/can-merge status/LGT1 One reviewer already commented LGTM status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants