Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

tracker: speed up create table by lower api (#1700) #1705

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1700

What problem does this PR solve?

close #1696

What is changed and how it works?

use CreateTableWithInfo API provided by TiDB

Check List

Tests

  • Unit test

Now create 100 tables cost 13 seconds

@ti-chi-bot ti-chi-bot added size/L status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick-for-release-2.0 labels May 19, 2021
@Ehco1996
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member Author

@Ehco1996: Thanks for your review. The bot only counts /lgtm from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Ehco1996
Copy link
Contributor

@Ehco1996: Thanks for your review. The bot only counts /lgtm from reviewers and higher roles in list, but you're still welcome to leave your comments.

@lance6716 @lichunzhu

it seems that i am still not in reviewer list , but #314 is merged >.<

@lance6716
Copy link
Collaborator

@Ehco1996: Thanks for your review. The bot only counts /lgtm from reviewers and higher roles in list, but you're still welcome to leave your comments.

@lance6716 @lichunzhu

it seems that i am still not in reviewer list , but #314 is merged >.<

need promotion like pingcap/community#449

@lance6716
Copy link
Collaborator

/lgtm

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label May 19, 2021
@lance6716 lance6716 added require-LGT1 for small PR, LGT1 is enough and removed status/LGT1 One reviewer already commented LGTM labels May 19, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label May 19, 2021
@lance6716
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 5ec1203

@ti-chi-bot ti-chi-bot merged commit 0c8826c into pingcap:release-2.0 May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
require-LGT1 for small PR, LGT1 is enough size/L status/can-merge status/LGT1 One reviewer already commented LGTM status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick-for-release-2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants